Skip to content

NSX Integration Documentation#378

Merged
nvazquez merged 5 commits intoapache:mainfrom
nvazquez:nsx-integration-docs
Sep 5, 2024
Merged

NSX Integration Documentation#378
nvazquez merged 5 commits intoapache:mainfrom
nvazquez:nsx-integration-docs

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jan 29, 2024 •
edited by github-actions bot
Loading

@nvazquez nvazquez requested review from NuxRo and Pearl1594 January 29, 2024 22:33
@nvazquez nvazquez changed the title NSX Integration Documentation [WIP] NSX Integration Documentation Jan 30, 2024
@Pearl1594
Copy link
Contributor

Pearl1594 commented Jan 30, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Jan 30, 2024

@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 30, 2024

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/378. (QA-JID 201)

@Pearl1594
Copy link
Contributor

Pearl1594 commented Jan 31, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Jan 31, 2024

@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 31, 2024

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/378. (QA-JID 202)

NuxRo
NuxRo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez marked this pull request as ready for review February 10, 2024 17:01
@nvazquez nvazquez changed the title [WIP] NSX Integration Documentation NSX Integration Documentation Feb 10, 2024
@nvazquez nvazquez mentioned this pull request Feb 10, 2024
Merged
12 tasks
@nvazquez
Copy link
Contributor Author

nvazquez commented Sep 5, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Sep 5, 2024

@nvazquez a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 5, 2024

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/378. (QA-JID 262)

Pearl1594
Pearl1594 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Not sure if we want to add a small note on adding support for non-rfc1918 compliant IPs.

@nvazquez nvazquez merged commit 0d71946 into apache:main Sep 5, 2024
@nvazquez nvazquez deleted the nsx-integration-docs branch September 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NuxRo NuxRo NuxRo approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nvazquez @Pearl1594 @blueorangutan @NuxRo